Skip to content

Conversation

@roryyorke
Copy link
Contributor

Use custom pytest mark noslycot for tests where slycot must not be installed to pass.

Extend use of pyest mark slycot to other tests using Slycot functions.

Follows on from coverage reduction in python-control/Slycot#250

Rory Yorke added 2 commits November 8, 2025 11:23
Test solvers dependent on Slycot when "slycot" test marker is
specified.  These tests are now parametrized by method.
Use custom pytest mark `noslycot` for tests where slycot must not be
installed to pass.

Extend use of pyest mark `slycot` to other tests using Slycot
functions.
@roryyorke
Copy link
Contributor Author

On my fork, the install_examples action failed on the first attempt, but passed on the second: https://github.com/roryyorke/python-control/actions/runs/19194480747/attempts/1. Has it been flaky before?

@coveralls
Copy link

Coverage Status

coverage: 94.734%. remained the same
when pulling faaa40e on roryyorke:rory/test-markers-2
into 2435a6a on python-control:main.

@murrayrm
Copy link
Member

murrayrm commented Nov 9, 2025

On my fork, the install_examples action failed on the first attempt, but passed on the second: roryyorke/python-control/actions/runs/19194480747/attempts/1. Has it been flaky before?

I've not seen that particular unit test fail before in that way. Definitely odd, since the test should be deterministic (?).

@murrayrm murrayrm merged commit 4242976 into python-control:main Nov 9, 2025
24 checks passed
@roryyorke roryyorke deleted the rory/test-markers-2 branch November 9, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants