Use pytest markers for slycot, cvxopt, and pandas tests #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 18, 2025 14:08
The pytest marker slycot is equivalent to the slycotonly decorator, and also allows slycot tests to be included or excluded at the pytest command-line.
The pytest marker cvxopt is equivalent to the cvxoptonly decorator, and also allows cvxopt tests to be included or excluded at the pytest command-line.
Contributor
Author
|
Is it expected that the |
Contributor
|
It only runs when one of the specified files in .github is changed: #821 |
Contributor
Author
|
Anyone had a look at this yet? Would like to merge this so Slycot tests can be clean, and we can move ahead with python-control/Slycot#250 . |
bnavigator
approved these changes
Nov 2, 2025
control/tests/conftest.py
Outdated
Comment on lines
9
to
10
| cvxoptonly = pytest.mark.skipif( | ||
| not control.exception.cvxopt_check(), reason="cvxopt not installed") |
Contributor
|
Yes, sorry for not getting back earlier. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using these markers allows selection of tests at the command-line, which is useful to focus on specific test types in development, and specifically allows testing only Slycot-dependent tests in Slycot CI.