Skip to content

scipy-based implementation of ss2tf #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
murrayrm merged 1 commit into from
Feb 1, 2025
Merged

scipy-based implementation of ss2tf #1108

murrayrm merged 1 commit into from
Feb 1, 2025

Conversation

@murrayrm
Copy link
Member

@murrayrm murrayrm commented Feb 1, 2025

This PR allows ss2tf to work using method=scipy for MIMO systems, allow MIMO ss2tf without requiring slycot. Also re-enabled unit tests that now work without slycot.

@coveralls
Copy link

coveralls commented Feb 1, 2025

Coverage Status

coverage: 94.659% (+0.01%) from 94.649%
when pulling e539c72 on murrayrm:mimo_ss2tf_scipy-12Jan2025
into ebff125 on python-control:main.

bnavigator
bnavigator approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@bnavigator bnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murrayrm murrayrm merged commit 92bd703 into python-control:main Feb 1, 2025
23 checks passed
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

3 participants

@murrayrm @coveralls @bnavigator