Repository navigation
phase_plot ODE function signature is not compatible with solve_ivp and StateSpace.dynamics #968
Description
There seems to be some inconsistency with the ordering of parameters for ODE functions between phase_plot and StateSpace.dynamics. phase_plot expects a function with signature f(x, t), whereas StateSpace.dynamics and other functions that are meant to be used with scipy.integrate.solve_ivp provide a function with the signature f(t, x) (note that the order of arguments is different).
It would be nice if the order of arguments was consistent, so you could pass functions compatible with scipy.integrate.solve_ivp directly to phase_plot.
Activity
sawyerbfuller commentedon Mar 5, 2024
Yes I agree,
phase_plothas the wrong parameter order, leftover from the previous convention. The docstring should also be updated to reference scipy's new integration scheme as well inscipy.integrate.solve_ivp.Please submit a pull request!
FeldrinH commentedon Mar 5, 2024
@murrayrm commented in #970 (comment) that he is rewriting parts of
phase_plot, so it might not be worthwhile for an external contributor to do a pull request changing the oldphase_plotcode right now.