Skip to content

Commit caa3e2c

Browse files
committed
FIX:
- result of singular_values_plot transposed to be in line with the "channel first" format - tests also updated consequently
1 parent a392c97 commit caa3e2c

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

control/freqplot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1172,7 +1172,7 @@ def singular_values_plot(syslist, omega=None,
11721172
fresp = fresp.transpose((2, 0, 1))
11731173
sigma = np.linalg.svd(fresp, compute_uv=False)
11741174

1175-
sigmas.append(sigma)
1175+
sigmas.append(sigma.transpose()) # return shape is "channel first"
11761176
omegas.append(omega_sys)
11771177
nyquistfrqs.append(nyquistfrq)
11781178

control/tests/freqresp_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ def ss_mimo_t():
532532
D = np.zeros((2, 2))
533533
T = TSys(ss(A, B, C, D))
534534
T.omega = 0.0
535-
T.sigma = np.array([[197.20868123, 1.39141948]])
535+
T.sigma = np.array([[197.20868123], [1.39141948]])
536536
return T
537537

538538

0 commit comments

Comments
 (0)