Better handling of missing dependencies on install and README improvements. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Raise an ImportError with informative message if scikit-build is not installed prior to executing setup.py. - Include numpy in the install_requires of the setup function so that it will be installed if not present.
Collaborator
|
This looks good, thanks. One point worth discussing is the switching of development status from alpha to beta. @murrayrm, I think this is fine, even overdue---are you ok with it? |
Member
|
Happy to upgrade the development status on PyPi to beta. Does it appear anywhere else? Update now or after this PR gets pushed out? |
Closed
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installed prior to executing setup.py.
will be installed if not present.