Build with scikit build #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- corrected transform.pyf, to not allocate zero-dim matrices - added tests for td04ad, one static, one checked against Octave with a transfer function set.
and works for 'C' as well as 'R' added a few tests
use conda-supplied compilers in meta.yaml fix flags for build on osx, specifically conda has python symbols in executable, needs -undefined dynamic_lookup
autodetection of available libraries (openblas/lapack) - deleted Slycot/slycot/setup.py - CMakeLists.txt in Slycot and Slycot/slycot - adapted Slycot/setup.py * Windows build needs specification of generator, e.g. python setup.py build -G "NMake Makefiles" * OSX and Linux builds select proper generator automatically
murrayrm
reviewed
Jul 11, 2018
conda-recipe-openblas/meta.yaml
Outdated
| - openblas >=0.3.0 | ||
| - libflang # [win] | ||
| - libgfortran # [not win] | ||
| - libgfortran # [not win] |
Member
Author
There was a problem hiding this comment.
dunno. Editing on windows gives me that stuff sometimes.... Will remove them.
conda-recipe/meta.yaml
Outdated
| - lapack | ||
| - libflang # [win] | ||
| - libgfortran # [not win] | ||
| - libgfortran # [not win] |
Member
|
Travis CI failed. Looks like it can't find Will try this out on my local machine when I get a chance (probably weekend, soonest). |
Member
Author
|
I forgot that I used pip to install a recent scikit-build. I see people are now working on a new release of scikit-build for conda-forge. I think it is best to pick things up when that happened. |
Contributor
|
It may work if you just add |
- conda builds now work - uses an ugly hack to get around lack of recent scikit-build in conda-forge
- use NMake as build type - Win only works with openblas - hack running vcvarsall again
- use CMAKE 3.12 policy recognizing BLAS_ROOT, LAPACK_ROOT - generate the version.py through cmake - remove/clean dependencies from installing scikit-build, in build.sh - correct the suffix used for the dll on mac osx
…lycot into build-with-scikit-build
Member
Author
|
Closing, superseded by PR #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After checking out the updated Slycot, I found that Windows builds were not working for me. Tried hunting down the differences, but could not get sufficient control over the Fortran side of the build process with numpy/setuptools. So I ended up implementing a pretty large change in the build system, using scikit-build to replace the numpy/setuptools based build system.
scikit-build wraps setuptools, and combines with CMake for the Fortran and C side of the builds. This enables more fine-grained control over the Fortran compilation, and selection of appropriate build generators. For Windows this uses NMake and Flang, for Linux this uses gnu make and fortran, for Mac it combines gfortran with clang and again gnu make.
Note: somehow the commit messages got mixed up? I did a merge+squash on a new branch, had proper messages locally, but here I have a bunch of old messages???
commit be8cdfa (HEAD -> build-with-scikit-build, origin/build-with-scikit-build)
Author: Rene van Paassen Rene.vanPaassen@gmail.com
Date: Wed Jul 11 22:24:49 2018 +0200
commit 2ee5339
Author: Rene van Paassen Rene.vanPaassen@gmail.com
Date: Wed Jul 11 22:14:55 2018 +0200