Skip to content

simplify version labeling and Git commit hash extraction #9

Closed

Description

@slivingston

Following comments on 5d21c69, we should simplify the code in setup.py that generates the version string that labels an installation of Slycot. This is somewhat nontrivial because, for non-release commits, it is useful to include the commit hash in the version string.

Two proposals have been made thus far:

  1. use versioneer (5d21c69)
  2. use make_version.py from python-control (5d21c69#commitcomment-20885735)

Interestingly, this is a perennial issue in the development of Python packages that have change history tracked in Git. Slycot requires compilation of FORTRAN code, so NumPy should be a good first reference regarding labeling built binary packages.

Activity

  1. roryyorke commented on Apr 23, 2019

    @roryyorke
    Collaborator

    @repagh I believe you've solved this with GIT_DESCRIBE_TAG in #52 - please reopen if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions