This repository was archived by the owner on Apr 15, 2024. It is now read-only.
fix txn token,dc and consistency#225
Open
amuhametov wants to merge 17 commits intopython-consul:masterfrom
Open
fix txn token,dc and consistency#225amuhametov wants to merge 17 commits intopython-consul:masterfrom
amuhametov wants to merge 17 commits intopython-consul:masterfrom
Conversation
Author
|
added auto-decode for values |
added 11 commits
August 6, 2018 12:21
Collaborator
|
Hi @amuhametov, Thank you for your PR! I will review your PR soon. Stay tuned! |
matusvalo
reviewed
Aug 27, 2018
| is_id=False, | ||
| index=False): | ||
| index=False, | ||
| txn=False): |
Collaborator
There was a problem hiding this comment.
Is it possible to add new parameters to docs string?
matusvalo
reviewed
Aug 27, 2018
| token=None, | ||
| consistency=None, | ||
| dc=None, | ||
| decode=False): |
Collaborator
There was a problem hiding this comment.
Not sure about this but I prefer to hide encoding/decoding logic from user. This will break API but it will be more clear. Is there any objection against it? Moreover, new parameters should be documented in doc string.
Collaborator
|
@amuhametov, I have added comments to your PR. In short:
|
added 4 commits
October 8, 2018 21:21
Author
|
@matusvalo are you sure we should break the API? |
Author
|
@cablehead @matusvalo guys? |
Author
|
ping |
|
#225 @amuhametov welcome to here
|
cablehead
force-pushed
the
master
branch
2 times, most recently
from
636f367 to
a91daae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #148