This repository was archived by the owner on Apr 15, 2024. It is now read-only.
#172_issue - kv_value returns string instead of bytes (in python3)#177
Closed
zofy wants to merge 10 commits intopython-consul:masterfrom
Closed
#172_issue - kv_value returns string instead of bytes (in python3)#177zofy wants to merge 10 commits intopython-consul:masterfrom
zofy wants to merge 10 commits intopython-consul:masterfrom
Conversation
zofy
commented
Oct 29, 2017
zofy
commented
- simple utf-8 decode added
- docstring updated
- kv get should be python2/3 compatible now
added 7 commits
October 29, 2017 19:33
- simple utf-8 decode added - docstring updated
- converting bytes to string done via utf-8 decoding - docstring updated
- converting bytes to string done via latin-1 decoding - docstring updated
- converting bytes to string done via latin-1 decoding - docstring updated - tests updated
- converting bytes to string done via latin-1 decoding - docstring updated - tests updated
- converting bytes to string done via latin-1 decoding - docstring updated - tests updated
Author
|
@cablehead Could you please have a look at changes I did? Basically, in python3 kv.get returns string instead of bytes now. Thank you! |
Collaborator
|
I added a comment to #172. Let me know if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.