feat: annotated argpare adding support for frozenset#1691
feat: annotated argpare adding support for frozenset#1691KelvinChung2000 wants to merge 2 commits into
Conversation
frozenset[T] joins list/set/tuple as a supported collection annotation: it registers the same single-arg collection resolver, coerces the parsed values into a frozenset, and rejects nested collections like the others. Adds a do_tags example and parametrizes the container runtime-cast test (which now also covers frozenset).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
==========================================
+ Coverage 99.57% 99.59% +0.01%
==========================================
Files 23 23
Lines 5678 5678
==========================================
+ Hits 5654 5655 +1
+ Misses 24 23 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
| float: _make_simple_resolver(float), | ||
| int: _make_simple_resolver(int), | ||
| Literal: _resolve_literal, | ||
| frozenset: _make_collection_resolver(frozenset), |
There was a problem hiding this comment.
While frozenset is functionally fully supported by this addition, the error messages and internal comments throughout the rest of the file were not updated to reflect this. For example, the user-facing error messages around L725 and L1575, and docstrings around L591 and L1291 still only mention list, set, and tuple. Consider updating these string literals across the file so the exceptions accurately list frozenset as a supported collection type.
Also recommend adding an entry to the CHANGELOG.md to help make this improvement discoverable.
2 participants
close #1685