Skip to content

Fixed handling of argparse's default options group name which was changed in Python 3.10#1125

Merged
kmvanbrunt merged 5 commits into
masterfrom
py310_fix
Jun 17, 2021
Merged

Fixed handling of argparse's default options group name which was changed in Python 3.10#1125
kmvanbrunt merged 5 commits into
masterfrom
py310_fix

Conversation

@kmvanbrunt

@kmvanbrunt kmvanbrunt commented Jun 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #1121

@kmvanbrunt
kmvanbrunt requested a review from anselor June 15, 2021 17:23
@codecov

codecov Bot commented Jun 15, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1125 (4ae47e0) into master (7fecaa7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4ae47e0 differs from pull request most recent head 1f5cbb6. Consider uploading reports for the commit 1f5cbb6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1125   +/-   ##
=======================================
  Coverage   98.49%   98.50%           
=======================================
  Files          22       22           
  Lines        4790     4808   +18     
=======================================
+ Hits         4718     4736   +18     
  Misses         72       72
Impacted Files Coverage Δ
cmd2/decorators.py 100.00% <ø> (ø)
cmd2/utils.py 97.92% <ø> (ø)
cmd2/argparse_custom.py 95.19% <100.00%> (+0.04%) ⬆️
cmd2/cmd2.py 98.39% <100.00%> (ø)
cmd2/ansi.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fecaa7...1f5cbb6. Read the comment docs.

@kmvanbrunt kmvanbrunt changed the title Fixed handling of argparse's default optionals group name that was changed in Python 3.10 Fixed handling of argparse's default options group name which was changed in Python 3.10 Jun 15, 2021
tleonhardt
tleonhardt previously approved these changes Jun 16, 2021
View reviewed changes
@tleonhardt

tleonhardt commented Jun 16, 2021

Copy link
Copy Markdown
Member

We need to fix it so our tests actually run on 3.10 - currently they are all being skipped

@anselor
anselor force-pushed the py310_fix branch 3 times, most recently from c443cfd to e15c965 Compare June 16, 2021 15:43
@tleonhardt

tleonhardt commented Jun 16, 2021

Copy link
Copy Markdown
Member

@anselor Your change broke it so it can't find a nox session and is failing. Previously it did find a nox session, but skipped all tests.

@anselor

anselor commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

@anselor Your change broke it so it can't find a nox session and is failing. Previously it did find a nox session, but skipped all tests.

Right, I'm trying to figure out what incantation makes both the CI targets and nox happy at the same time.

@anselor

anselor commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

@kmvanbrunt It's now testing 3.10 and reporting errors.

@kmvanbrunt
kmvanbrunt force-pushed the py310_fix branch 2 times, most recently from e93dc8c to 3f5a235 Compare June 16, 2021 17:58
@anselor
anselor force-pushed the py310_fix branch 2 times, most recently from 4b41ce7 to 497c0ea Compare June 16, 2021 21:01
tleonhardt
tleonhardt previously approved these changes Jun 16, 2021
View reviewed changes
Comment thread azure-pipelines.yml
kmvanbrunt and others added 5 commits June 17, 2021 12:51
@kmvanbrunt @anselor
Fixed handling of argparse's default options group name which was cha…
7c9ecee 
…nged in Python 3.10
@anselor
Setting the version in nox to just '3.10' appears to allow 3.10.0b2 t…
61b2adb 
…o run for me

github CI appears to require full beta version number which is incompatably with how nox wants the version passed in.
Changed CI to run test targets without specifying version and relying on nox to auto-skip unsupported versions
Added Python 3.10 to azure pipelines.
@kmvanbrunt @anselor
Fixing tests on Python 3.10
0d945ff
@kmvanbrunt @anselor
Updated all examples to use Cmd2ArgumentParser instead of argparse.Ar…
00d4bd5 
…gumentParser.

This is best practice for consistency of appearance between built-in and custom commands.
@anselor
Trying to isolate beta
1f5cbb6
@kmvanbrunt
kmvanbrunt merged commit 7311a74 into master Jun 17, 2021
@kmvanbrunt
kmvanbrunt deleted the py310_fix branch June 17, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tleonhardt tleonhardt tleonhardt left review comments
@anselor anselor Awaiting requested review from anselor
@kotfu kotfu Awaiting requested review from kotfu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

argparse-related test failures on Python 3.10

3 participants

@kmvanbrunt @tleonhardt @anselor