Skip to content

fix(libpython): link libintl so _localemodule resolves on macOS #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjmjohnson wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

fix(libpython): link libintl so _localemodule resolves on macOS #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmake/libpython/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,14 @@ set(LIBPYTHON_TARGET_LIBRARIES
if(HAVE_LIBDL)
list(APPEND LIBPYTHON_TARGET_LIBRARIES ${HAVE_LIBDL})
endif()
if(HAVE_LIBINTL)
# _localemodule uses libintl_* (bindtextdomain, dcgettext, ...) when
# HAVE_LIBINTL_H is set. Where libintl is a separate library (e.g. macOS
# gettext), link it so those symbols resolve; mirrors CPython configure's
# `LIBS += -lintl`. On glibc the functions are in libc and HAVE_LIBINTL is
# unset, so this is a no-op there.
list(APPEND LIBPYTHON_TARGET_LIBRARIES ${HAVE_LIBINTL})
endif()
if(WITH_THREAD OR PY_VERSION VERSION_GREATER_EQUAL "3.7")
list(APPEND LIBPYTHON_TARGET_LIBRARIES ${CMAKE_THREAD_LIBS_INIT})
endif()
Expand Down