Skip to content

fix: linking error building _testcapi in Python 3.12 #434 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrej730 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: linking error building _testcapi in Python 3.12 #434 #435

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
092a2af
fix: linking error building `_testcapi` in Python 3.12
Andrej730 Dec 6, 2025
c92f2fc
Define Py_LIMITED_API only for 3.12
Andrej730 Dec 6, 2025
31e8fa1
Remove TODO in the note
Andrej730 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmake/extensions/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ set(IS_PY3_12_OR_GREATER 0)
if(PY_VERSION VERSION_GREATER_EQUAL "3.12")
set(IS_PY3_12_OR_GREATER 1)
endif()
math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")

add_python_extension(array ${WIN32_BUILTIN} SOURCES arraymodule.c)
add_python_extension(audioop ${WIN32_BUILTIN}
Expand Down Expand Up @@ -190,6 +191,9 @@ add_python_extension(_testcapi NEVER_BUILTIN
$<$<VERSION_EQUAL:${PY_VERSION_MAJOR}.${PY_VERSION_MINOR},3.12>:_testcapi/pytime.c>
$<$<VERSION_EQUAL:${PY_VERSION_MAJOR}.${PY_VERSION_MINOR},3.12>:_testcapi/sys.c>
$<$<VERSION_EQUAL:${PY_VERSION_MAJOR}.${PY_VERSION_MINOR},3.12>:_testcapi/vectorcall_limited.c>

# Limited API in 3.12, but in 3.13 all limited API files were moved to `_testlimitedcapi`.
DEFINITIONS $<$<VERSION_EQUAL:${PY_VERSION},3.12>:Py_LIMITED_API=0x${_limited_api_version}0000>
)

set(thread_REQUIRES)
Expand Down Expand Up @@ -282,7 +286,6 @@ add_python_extension(_tracemalloc ALWAYS_BUILTIN
_tracemalloc.c
)
add_python_extension(_weakref ALWAYS_BUILTIN SOURCES _weakref.c)
math(EXPR _limited_api_version "${PY_VERSION_MAJOR} * 100 + ${PY_VERSION_MINOR}")
add_python_extension(xxlimited REQUIRES BUILD_TESTING
SOURCES xxlimited.c
DEFINITIONS $<$<VERSION_LESS:${PY_VERSION},3.10>:Py_LIMITED_API=0x${_limited_api_version}0000>
Expand Down