Run pylint as separate GH action - #193
Merged
crobinso merged 1 commit intoFeb 8, 2024
Merged
Conversation
Contributor
Author
|
I noticed, that there is also |
crazyscientist
commented
Oct 13, 2023
| val = convert(val) | ||
| ret[key] = val | ||
|
|
||
| def add_dict(key, add, remove, _set=None, convert=None): |
Contributor
Author
There was a problem hiding this comment.
If I'm not mistaken, all uses of convert inside of the method were removed by #190. Now pylint complained about the argument not being used.
I checked with grep and this method never receives 5 arguments.
Member
There was a problem hiding this comment.
yes that looks correct. you could send this bit as a separate PR while we figure out fate of pylint CI
Contributor
Author
|
All tests passed ✔️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 2192 2192
=========================================
Hits 2192 2192 ☔ View full report in Codecov by Sentry. |
* Allow lines to be 100 characters long. * Pinned pylint version
crazyscientist
force-pushed
the
185-pylint-integration
branch
from
February 8, 2024 08:30
fa8733f to
1309914
Compare
crobinso
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and allow lines to be 100 characters long.
This closes #185