Include alias in include_fields (closes #170) - #186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 2190 2200 +10
=========================================
+ Hits 2190 2200 +10
☔ View full report in Codecov by Sentry. |
|
@crobinso or should I have just removed the code for sorting in |
|
This needs to be rebased now, there's conflicts. IMO we should not add the non-list include_fields safety checks. There's other parts in the code like
No, IIRC there were explicit complaints when I tried to remove that in the past :( |
…is an alias (closes python-bugzilla#170) Because the `_getbugs` method tries to return bug data in the same order as IDs and aliases are provided, the `alias` needs to be explicitly added to `include_fields`.
f3210aa to
0607200
Compare
OK, I've removed that part. |
2 participants
Include
aliasininclude_fields, when the parameter forgetbugis an alias (closes #170)Because the
_getbugsmethod tries to return bug data in the same order as IDs and aliases are provided, thealiasneeds to be explicitly added toinclude_fields.