Skip to content

Commit e661fe1

Browse files
committed
Some fixes to work with RHEL6 python2.6
1 parent 2571514 commit e661fe1

7 files changed

Lines changed: 14 additions & 10 deletions

File tree

bin/bugzilla

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import socket
2323
import sys
2424
import tempfile
2525

26-
if sys.version_info.major >= 3:
26+
if hasattr(sys.version_info, "major") and sys.version_info.major >= 3:
2727
# pylint: disable=F0401,W0622
2828
from xmlrpc.client import Fault, ProtocolError
2929
basestring = (str, bytes)
@@ -59,7 +59,7 @@ def to_encoding(ustring):
5959
elif ustring is not None:
6060
string = str(ustring)
6161

62-
if sys.version_info.major >= 3:
62+
if hasattr(sys.version_info, "major") and sys.version_info.major >= 3:
6363
return string
6464
else:
6565
return string.encode(locale.getpreferredencoding(), 'replace')
@@ -968,7 +968,9 @@ def _do_modify(bz, parser, opt, args):
968968
"devel": (add_devwb, rm_devwb),
969969
}
970970

971-
wbmap = {k: v for k, v in wbmap.items() if wbmap[k][0] or wbmap[k][1]}
971+
for k, v in wbmap.copy().items():
972+
if not v[0] and not v[1]:
973+
del(wbmap[k])
972974

973975
log.debug("update bug dict=%s", update)
974976
log.debug("update flags dict=%s", flags)

bugzilla/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import sys
1616
from logging import getLogger
1717

18-
if sys.version_info.major >= 3:
18+
if hasattr(sys.version_info, "major") and sys.version_info.major >= 3:
1919
# pylint: disable=F0401
2020
from xmlrpc.client import Fault, ServerProxy
2121
else:

bugzilla/base.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
from io import BytesIO
1717

18-
if sys.version_info.major >= 3:
18+
if hasattr(sys.version_info, "major") and sys.version_info.major >= 3:
1919
# pylint: disable=F0401,E0611
2020
from configparser import SafeConfigParser
2121
from http.cookiejar import LoadError, LWPCookieJar, MozillaCookieJar
@@ -969,7 +969,9 @@ def build_query(self,
969969
}
970970

971971
# Strip out None elements in the dict
972-
query = {k: v for k, v in query.items() if v is not None}
972+
for k, v in query.copy().items():
973+
if v is None:
974+
del(query[k])
973975
return query
974976

975977
def _query(self, query):

tests/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import shlex
99
import sys
1010

11-
if sys.version_info.major >= 3:
11+
if hasattr(sys.version_info, "major") and sys.version_info.major >= 3:
1212
from io import StringIO
1313
else:
1414
from StringIO import StringIO

tests/query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ class RHBZTest(BZ4Test):
243243
'sub_components': ["Command-line tools (RHEL5)"]}
244244

245245

246-
class TestURLToQuery(unittest.TestCase):
246+
class TestURLToQuery(BZ34Test):
247247
def _check(self, url, query):
248248
self.assertDictEqual(bz4.url_to_query(url), query)
249249

tests/rw_functional.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import sys
1818
import unittest
1919

20-
if sys.version_info.major >= 3:
20+
if hasattr(sys.version_info, "major") and sys.version_info.major >= 3:
2121
# pylint: disable=F0401,E0611
2222
from urllib.parse import urlparse
2323
else:

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = py27,py33
2+
envlist = py26,py27,py33
33

44
[testenv]
55
deps=

0 commit comments

Comments
 (0)