Repository navigation
Conversation
Like `update --check`, it reports whether the output file is up to date without writing it. POT-Creation-Date is ignored, and a missing output file counts as out of date, as with `update --check --init-missing`. Fixes python-babel#900 Signed-off-by: Christopher Krah <48338417+chrikrah@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 93.62% 93.70% +0.07%
==========================================
Files 27 27
Lines 4973 4987 +14
==========================================
+ Hits 4656 4673 +17
+ Misses 317 314 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #900.
pybabel extract --checkwrites nothing and fails when the POT file would change, ignoring POT-Creation-Date.A missing file fails the check, the way
update --check --init-missingtreats a catalog it would create (frontend.py#L809-L812). In CI that catches a POT nobody committed yet. Should a missing file pass instead?