Repository navigation
Compile compact exponent operands for gettext and JavaScript plural rules - #1440
Open
shrohan2003 wants to merge 1 commit into
Open
shrohan2003 wants to merge 1 commit into
shrohan2003 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated gettext expressions can contain an undeclared
eorc, which makes them invalid for gettext. The JavaScript generator inherits the same problem. For example, compilinge = 0 and n = 1raises an invalid-token error when used with Python’s gettext evaluator.Both compilers now use zero for the compact exponent of an ordinary number, matching Babel’s Python evaluator. Tests exercise both operand spellings and evaluate the generated gettext expression.