Repository navigation
Conversation
When a preferred locale wasn't available, negotiate_locale only tried its first subtag, so a three-part identifier could never match on language and script. With ['zh', 'zh_Hant'] available, zh_Hant_TW resolved to zh (Simplified), sr_Latn_RS with ['sr', 'sr_Latn'] resolved to sr (Cyrillic), and zh_Hant_TW with only ['zh_Hant'] didn't match at all. Drop subtags from the end one at a time instead, which is the RFC 4647 lookup order.
Member
|
Is this an actual issue you ran into? |
Author
|
No, not in a real app. It came up while trying identifiers with a script subtag: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a preferred locale isn't available,
negotiate_localeonly tries its first subtag, so a three-part identifier can't match on language + script:This drops subtags from the end one at a time instead (the RFC 4647 lookup order). Two-part identifiers behave as before.