Add a backport of generic NamedTuples
#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
May 20, 2022
Member
Author
|
I think this is now ready for review! |
srittau
reviewed
May 21, 2022
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
I don't really claim to know what's going in this code, but everything seems reasonable and makes sense to me, but I have a few small remarks.
srittau
approved these changes
May 21, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thank you! I have a few small comments.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
AlexWaygood
commented
May 21, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
approved these changes
May 21, 2022
Member
|
Thank you! |
Member
Author
|
Thank you! Super excited to see this happen :D |
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the ability, added in python/cpython#92027, to define generic
NamedTupleclasses. The implementation and the tests are very similar to the implementation on the CPythonmainbranch, with a few tweaks so that it all works on earlier versions of Python as well.#7