Move builtin protocol whitelist to mapping instead of list#128
Merged
JelleZijlstra merged 4 commits intopython:mainfrom Apr 5, 2023
Merged
Move builtin protocol whitelist to mapping instead of list#128JelleZijlstra merged 4 commits intopython:mainfrom
JelleZijlstra merged 4 commits intopython:mainfrom
Conversation
and rename _PROTO_WHITELIST to _PROTO_ALLOWLIST taken from python/cpython#15647 and python/cpython#21825
taken from python/cpython#15647 and python/cpython#21823
|
All commit authors signed the Contributor License Agreement. |
AlexWaygood
reviewed
Apr 1, 2023
blank line contains whitespace Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Apr 1, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Apr 5, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM. The added test does indeed fail with the current latest version of typing_extensions on Python 3.7, and this is the fix that was applied in CPython.
JelleZijlstra
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport from:
python/cpython#15647
Also rename to allowlist, following these changes:
python/cpython#21823
python/cpython#21825