feat: add ty #2137
feat: add ty #2137
Conversation
|
All commit authors signed the Contributor License Agreement. |
| @@ -1 +1 @@ | |||
| version = "pyrefly 0.45.2" | |||
| version = "pyrefly 0.46.0" | |||
There was a problem hiding this comment.
This auto-updated, please let me know if this should be reverted.
| line_to_errors.setdefault(int(lineno), []).append(line) | ||
| return line_to_errors | ||
|
|
||
| class TyTypeChecker(TypeChecker): |
There was a problem hiding this comment.
This is entirely based on the Pyright checker.
| _, lineno, kind, _ = line.split(":", maxsplit=3) | ||
| kind = kind.split()[-1] | ||
| a.add(kind) | ||
| if kind not in ("major", "minor"): |
There was a problem hiding this comment.
Not sure if we want to re-map these to error and warning but this seems to work fine-ish?
|
|
||
| def run_tests(self, test_files: Sequence[str]) -> dict[str, str]: | ||
| command = [sys.executable, "-m", "ty", "check", ".", "--output-format", "gitlab"] | ||
| proc = run(command, stdout=PIPE, text=True, encoding="utf-8") |
There was a problem hiding this comment.
gitlab seems to be the only json output mode.
SimonSchick
force-pushed
the
feat/add-ty
branch
from
836e216 to
d474d74
Compare
|
Thanks, but folk from ty don't yet want to add themselves to the conformance suite |
|
@SimonSchick, are you working with the Astral team on this? Ty is still in prerelease, so I've been waiting for them to give the green light before adding them to the conformance tests. If you have their approval, then great. Otherwise, I think we should hold off on this. |
|
I do not but you are welcome to continue this PR at a later time. |
3 participants
See https://docs.astral.sh/ty/
I'm uncertain what steps need to be taken to mark tests as unsupported rather than
Unknownin bulk.Should I mark all failing tests as
unsupportedfor the time being?