Switch order of dataclass decorator overloads#9743
Merged
hauntsaninja merged 2 commits intoFeb 17, 2023
Merged
Conversation
hauntsaninja
approved these changes
Feb 16, 2023
hauntsaninja
left a comment
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Ooo, --no-strict-optional in 2023 is bold ;-) But this looks good, thank you!
Collaborator
|
You can ignore CI failures, they're related to new Python versions being released and will be fixed by #9742 |
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When type checking in a non-strict Optional context where
Noneinhabits all types, thetype[_T]-type overload will always resolve over theNone-type overload. Switching the order of these better represents the priority of overloads when running in this context. mypy ensures that listing an overload with aNoneargument second in non-strict-optional order results in a type error: https://github.com/python/mypy/blob/83660d0ad72ab5a61cea5fe5955e66c33ef54111/test-data/unit/check-overloading.test#L4619