create_datagram_endpoint expects a str when family=AF_UNIX#9574
Merged
Conversation
Since python 3.7, asyncio.loop.create_datagram_endpoint expects the arguments `local_addr` and `remote_addr` to be `str` or `None` when the argument family=`socket.AF_UNIX` and the argument `sock` is `None` or also a unix socket. Here is a link to the relevant line in the standard library: https://github.com/python/cpython/blob/main/Lib/asyncio/base_events.py#L1319 And here is a link to the pull request for the change which introduced this in python 3.7: python/cpython#3164
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Please note that Python 3.7 is the minimum version we support in typeshed, so there's no need for an extra branch for Python >= 3.7. |
Author
|
thanks, i think i've fixed it now. i was going off the versions file which lists 3.4 as the minimum version but i am probably reading it wrong. |
AlexWaygood
reviewed
Jan 21, 2023
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jan 21, 2023
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since python 3.7,
asyncio.loop.create_datagram_endpointexpects the argumentslocal_addrandremote_addrto bestrorNonewhen the argumentfamilyissocket.AF_UNIX(and if whensockis notNone, it is also a unix socket). Here is a link to the relevant line in the standard library: https://github.com/python/cpython/blob/main/Lib/asyncio/base_events.py#L1319Here is a link to the pull request on the cpython repository which effected this change: python/cpython#3164
i'm not at all sure if I've made the changes correctly. is there a way to represent the dependency on the
familyargument that i'm missing?