Skip to content

pycocotools: Add numpy as a dependency #9518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlexWaygood wants to merge 1 commit into from
Closed

pycocotools: Add numpy as a dependency #9518

AlexWaygood wants to merge 1 commit into from

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jan 13, 2023

Source code here: https://github.com/cocodataset/cocoapi/tree/master/PythonAPI/pycocotools.

I'm in large part trusting that the commented-out annotations here are correct. From what I can tell from the source code, they look pretty good, but I haven't verified.

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Jan 13, 2023 •
edited
Loading

Oh, pycocotools doesn't declare numpy as a dependency. There goes that idea 🤷‍♂️

A bit of a shame.

@AlexWaygood AlexWaygood deleted the pycocotools branch January 13, 2023 01:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam
Copy link
Collaborator

Avasam commented Jan 14, 2023 •
edited
Loading

@AlexWaygood Could still be worth updating the TODOs since they're no longer blocked by #5768 . PyInstaller has a similar comment concerning modulegraph (which we opted to just partially type the vendored version instead of referencing the original package)

@Avasam
Copy link
Collaborator

Avasam commented Jan 14, 2023 •
edited
Loading

Weird, I just checked, this is their setup.py:
setup.py.txt

And this is their .eggs-info/requires:
requires.txt

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Jan 14, 2023 •
edited
Loading

Weird, I just checked, this is their setup.py: setup.py.txt

And this is their .eggs-info/requires: requires.txt

It's because pycocotools doesn't ship wheels, and the stub-uploader is currently only able to parse wheels, not sdists: https://github.com/typeshed-internal/stub_uploader/blob/022168078ff4f6ef99fa79401fc1a98c8ad0f326/stub_uploader/metadata.py#L205-L207

See also: the same problem with click-default-group here: #9304 (comment)

@Avasam Avasam mentioned this pull request Jan 14, 2023
Merged
@Avasam
Copy link
Collaborator

Avasam commented Feb 20, 2023

This would help: typeshed-internal/stub_uploader#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexWaygood @Avasam