Skip to content

Fix some Any subclassing in tqdm #9505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 4 commits into from
Jan 13, 2023
Merged

Fix some Any subclassing in tqdm #9505

AlexWaygood merged 4 commits into from
Jan 13, 2023

Conversation

@Avasam
Copy link
Collaborator

@Avasam Avasam commented Jan 12, 2023 •
edited
Loading

Fixes 4 2 Any subclassing issues by replicating the types used in external modules.
The rich one isn't complete as it was starting to get quite complex (I don't wanna re-implement the entire library's types either!)

Ref: #9491

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keras and dask changes look great. Mind splitting the rich changes off into a separate PR? They're a little more complex and my brain's going a little fuzzy thinking about nominal vs structural subtyping 😅

@Avasam Avasam changed the title Fix Any subclassing in tqdm Fix some Any subclassing in tqdm Jan 13, 2023
@Avasam Avasam requested a review from AlexWaygood January 13, 2023 02:51
@Avasam
Copy link
Collaborator Author

Avasam commented Jan 13, 2023 •
edited
Loading

The keras and dask changes look great. Mind splitting the rich changes off into a separate PR? They're a little more complex and my brain's going a little fuzzy thinking about nominal vs structural subtyping 😅

If it feels too complex for our needs, I can always make more things Incomplete. We mostly need the structure just to fix the Any subclassing, detailed types are bonuses.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AlexWaygood
AlexWaygood approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood merged commit 102a8fa into python:main Jan 13, 2023
@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 13, 2023

The keras and dask changes look great. Mind splitting the rich changes off into a separate PR? They're a little more complex and my brain's going a little fuzzy thinking about nominal vs structural subtyping 😅

If it feels too complex for our needs, I can always make more things Incomplete. We mostly need the structure just to fix the Any subclassing, detailed types are bonuses.

Maybe we could start off with something simpler for now? We can always refine it in the future :)

@Avasam Avasam deleted the tqdm-any-subclassing branch January 13, 2023 11:44
@Avasam Avasam mentioned this pull request Jan 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avasam @AlexWaygood