Improve mypy flags for regr_test.py and typecheck_typeshed.py #9441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant flags that are now enabled by default - Add --pretty to type_check_typeshed.py
Member
|
No strong feelings here, but there's some value in keeping these flags even if they are enabled by default: it's more explicit, and we are insulated against changes if mypy decides to flip the default again in the future. |
Member
Author
|
Fair points. I guess I'm still weakly in favour of this PR — it feels unlikely that these changes to the mypy defaults will be reverted, and the added value from explicitness feels a little slim to me here :) |
srittau
approved these changes
Jan 2, 2023
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
LGTM, I slightly prefer to remove the redundant options, but have no really strong feelings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--prettytotypecheck_typeshed.py.mypy_test.pyflags are being reworked in #9408.