Skip to content

Revert __eq__ removal #8487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srittau merged 1 commit into from
Aug 4, 2022
Merged

Revert __eq__ removal #8487

srittau merged 1 commit into from
Aug 4, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 4, 2022 •
edited
Loading

Because __eq__ is treated specially by mypy when strict_equality is turned on.
Without __eq__ on a type, mypy raises this error:

class A:
    def __eq__(self, o: object) -> bool: ...

class B: ...

if A() == 1:  # ok
    ...

if B() == 1: # error: Non-overlapping equality check (left operand type: "B", right operand type: "Literal[1]")
    ...

Refs #8483

@sobolevn sobolevn changed the title Revert __eq__ removal, refs #8483 Revert __eq__ removal Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit a03e8b4 into python:master Aug 4, 2022
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Aug 4, 2022

Thanks for catching this!

@AlexWaygood AlexWaygood mentioned this pull request Aug 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @hauntsaninja @srittau