stdlib: audit more callback annotations - #8209
Merged
Merged
Conversation
AlexWaygood
marked this pull request as ready for review
June 29, 2022 22:49
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
Jun 29, 2022
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
Jun 29, 2022
AlexWaygood
commented
Jun 29, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| __all__ = ["scheduler"] | ||
|
|
||
| _ActionCallback: TypeAlias = Callable[..., Any] |
Member
There was a problem hiding this comment.
Suggested change
| _ActionCallback: TypeAlias = Callable[..., Any] | |
| _ActionCallback: TypeAlias = Callable[..., object] |
Looks like the return value is ignored
Member
Author
There was a problem hiding this comment.
It's used as an attribute annotation as well, though, and I wanted to avoid unexpected false positives on code like
e: Event
x = e.action()
x.foo()I'm not sure if it makes sense to do that, but I didn't want to accidentally cause a regression. Same for _WriterCallback in wsgiref.validate.
| def writelines(self, seq: Iterable[str]) -> None: ... | ||
| def close(self) -> NoReturn: ... | ||
|
|
||
| _WriterCallback: TypeAlias = Callable[[bytes], Any] |
Member
There was a problem hiding this comment.
Suggested change
| _WriterCallback: TypeAlias = Callable[[bytes], Any] | |
| _WriterCallback: TypeAlias = Callable[[bytes], object] |
Return value is ignored
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant to PyCQA/flake8-pyi/issues/237