Add __class_getitem__ to classes in logging and csv#7830
Merged
AlexWaygood merged 6 commits intopython:masterfrom May 17, 2022
Merged
Add __class_getitem__ to classes in logging and csv#7830AlexWaygood merged 6 commits intopython:masterfrom
__class_getitem__ to classes in logging and csv#7830AlexWaygood merged 6 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
May 11, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
Author
|
@srittau, just to check, are you happy with me merging this one? I don't think there's any way to do the import without the |
srittau
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__class_getitem__tologging.LoggerAdapterandlogging.StreamHandlercpython#92129