Add new arguments to subprocess.Popen #7798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most recent one in python/cpython#23930. This makes me wish we could have had type evaluation functions.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
changed the title
Collaborator
|
"subprocess.💩en", Jelle tell us how you really feel |
Akuli
approved these changes
May 7, 2022
Collaborator
Akuli
left a comment
Akuli
left a comment
There was a problem hiding this comment.
Reviewed by diffing the overloads against each other.
| pipesize: int = ..., | ||
| ) -> Popen[Any]: ... | ||
| elif sys.version_info >= (3, 9): | ||
| # user, group, extra_groups, umask were added in 3.9 |
Collaborator
There was a problem hiding this comment.
These shouldn't be available on windows, but we probably shouldn't change the stub to reflect that. It's already difficult enough to read. The same goes for process_group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most recent one in python/cpython#23930. This makes me wish we
could have had type evaluation functions.