Add filters to stdlib.warnings.pyi - #5889
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Aug 8, 2021
hramezani
force-pushed
the
warnings_filter
branch
from
August 8, 2021 17:33
65f43be to
7ceae1c
Compare
Akuli
reviewed
Aug 8, 2021
Akuli
left a comment
Akuli
left a comment
Collaborator
There was a problem hiding this comment.
There are conflicts. Please run git pull https://github.com/python/typeshed and then resolve them.
hramezani
force-pushed
the
warnings_filter
branch
from
August 8, 2021 17:42
7ceae1c to
39cbeab
Compare
Collaborator
|
One more nit: Don't use |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Sorry for the conflict. I've addressed your comment based on your suggestion. |
Akuli
approved these changes
Aug 8, 2021
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bluetech suggested adding
filterstowarnings.pyi.