Conversation
srittau
reviewed
May 10, 2021
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, but one question below.
| version = "0.1" | ||
| python2 = true | ||
| version = "1.0" | ||
| python2 = false |
Collaborator
There was a problem hiding this comment.
According to croniter's setup.py, Python 2 is still supported. Any reason to drop it here?
Collaborator
|
Please ignore the CI failure, this is a bug in our CI scripts. mypy_primer ran without finding a difference. |
Collaborator
|
(Note that it would be very unexpected if mypy primer did find a difference, because since modular typeshed it does not check changes to third party stubs) |
Member
|
@sbv-csis are you still interested in moving this forward? |
Collaborator
|
Merged master into this because it conflicted with #5872. |
Collaborator
|
I am going to close this for now as there hasn't been any responses to the feedback left. Please reopen it if there is still interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest versions of croniter a new
hash_idargument has been added to the__init__