Add partial stubs for mailbox in Python 3 #3489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suutari-ai
force-pushed
the
mailbox-stubs
branch
from
001416a to
797a4f4
Compare
These stubs cover Message, MaildirMessage, Mailbox and Maildir classes and the exception classes (*Error). The stubs for other mailbox subclasses (mbox, MMDF, MH, Babyl), and their corresponding message classes are incomplete.
suutari-ai
force-pushed
the
mailbox-stubs
branch
from
797a4f4 to
52bd069
Compare
Member
|
We just added mailbox stubs in #3427. Do those cover your use case? |
Contributor
Author
|
Oops, I should have checked the master branch. Created the PR from a submodule in mypy so of course I didn't have the latest changes. Doh! It seems however that those are not entirely correct, since I get this error with my working code: Maybe I'll create another PR to improve the stubs in master. |
Contributor
Author
|
Yep, the mailbox module in master will cover my use cases as soon as #3490 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These stubs cover Message, MaildirMessage, Mailbox and Maildir classes
and the exception classes (*Error).
The stubs for other mailbox subclasses (mbox, MMDF, MH, Babyl), and
their corresponding message classes are incomplete.