Further improve codecs stubs #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove header comments - uppercase type aliases - remove old-style type annotations - unquote forward refs
gvanrossum
approved these changes
Jun 12, 2018
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I like the style improvements. I've not reviewed every single line, sorry.
Member
Author
|
CI is broken because some other stub was using the private type aliases, I'll fix it soon. |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
- remove header comments - uppercase type aliases - remove old-style type annotations - unquote forward refs - reformat the file - remove values for globals - don't use private names from codecs stub in io.pyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up with @gvanrossum's comments on #2114, with a number of other changes.
This PR just changes formatting and renames internal type aliases; there should be no user-visible change.