remove all lxml stubs for now #1664
Conversation
|
That doesn't work because mypy itself needs lxml. @gvanrossum what are your thoughts? Should mypy check itself with more permissive flags? |
|
There are only three imports of lxml in mypy (two in tests). Maybe we should just put |
|
is there any advice how to proceed with incomplete stubs? i'm thinking of another repository or a branch here (possibly in plural if scoped on one library) to compile stubs as users need them until considered complete to get integrated here. for |
|
I think the best solution is to make a separate repo, like https://github.com/JelleZijlstra/sqlalchemy-stubs. Unfortunately, support for using such stubs is currently kind of hacky—PEP 561 (https://www.python.org/dev/peps/pep-0561/) will make that better once it's implemented. |
See python/typeshed#525 and python/typeshed#1664. We decided to remove the lxml stubs because they cause problems so frequently. However, this requires small tweaks to mypy's own usage of lxml. My plan is to proceed as follows: - Merge this PR, adding type ignores and removing warn_unused_ignores from mypy's self-check config. - Merge python/typeshed#1664, which should pass Travis after his PR is merged. - Add "warn_unused_ignores" back to mypy's self-check config. I confirmed that this PR passes tests both with and without the lxml stubs being present.
See python/typeshed#525 and python/typeshed#1664. We decided to remove the lxml stubs because they cause problems so frequently. However, this requires small tweaks to mypy's own usage of lxml. My plan is to proceed as follows: - Merge this PR, adding type ignores and removing warn_unused_ignores from mypy's self-check config. - Merge python/typeshed#1664, which should pass Travis after his PR is merged. - Add "warn_unused_ignores" back to mypy's self-check config. I confirmed that this PR passes tests both with and without the lxml stubs being present.
Followup from #4217 and python/typeshed#1664.
|
Thanks Guido! |
Followup from #4217 and python/typeshed#1664.
Followup from #4217 and python/typeshed#1664. Also had to change a few types to `Any` because of the missing lxml stubs.
3 participants
Fixes #525.
As discussed there, these stubs are too incomplete and frequently cause problems.