Fix type of ssl.Options.OP_ALL - #16380
Merged
Merged
Conversation
srittau
approved these changes
Sep 10, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16378
Options.OP_ALLwas declared asOP_ALL: int(since #15589, because its runtime value differs between OpenSSL builds), which makes type checkers treat it as a non-member attribute of typeintrather than an enum member. SoOptions.OP_ALLis not assignable toOptions, unlike every other flag in the class.Per the typing spec for enums in stubs, a member whose value we don't want to pin can be declared as
OP_ALL = ..., as suggested by @srittau in the issue. That's what this PR does.Verified locally with the issue's reproducer (
--custom-typeshed-dirpointing at this branch):Revealed type is "int"+Argument 1 to "f" has incompatible type "int"; expected "Options"; after →Revealed type is "Literal[ssl.Options.OP_ALL]?", no errors.Type of "Options.OP_ALL" is "Literal[Options.OP_ALL]", 0 errors.stubtest ssl(py3.11, linux allowlists): no issues, same as main.tests/mypy_test.py stdlib/ssl.pyi -p 3.11 -p 3.13: success.