Conversation
|
Part of #15358. |
This comment has been minimized.
This comment has been minimized.
|
This can only be done at the same time as removing the second branch here: typeshed/stdlib/asyncio/queues.pyi Lines 7 to 10 in 7ff653f |
This comment has been minimized.
This comment has been minimized.
ruff disagrees. :P |
|
Ohhh, CI now passes here because you removed the pyright-3.9 CI check in the other PR. Hmm, but I'd still lean towards removing the second branch here at the same time as rearranging the order of the base classes? Pyright's previous complaint -- which is what prompted the >>> from typing import Generic, TypeVar
>>> _T = TypeVar("_T")
>>> _LoopBoundMixin = object
>>> class Queue(_LoopBoundMixin, Generic[_T]): ...
...
Traceback (most recent call last):
File "<python-input-3>", line 1, in <module>
class Queue(_LoopBoundMixin, Generic[_T]): ...
TypeError: Cannot create a consistent method resolution order (MRO) for bases object, Generic |
|
Makes sense. I've deferred this for now, and added it to #13782. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
(2026-02-09) Deferred until Python 3.9 branches are removed (expected May 2026).