a close reading of the pickle module - #12971
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
tungol
marked this pull request as draft
November 7, 2024 06:32
tungol
marked this pull request as ready for review
November 7, 2024 07:00
tungol
commented
Nov 7, 2024
this is probably better
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't go in planning to split the C
_pickle.Pickerand pythonpickle._Picklerimplementations, but then the _Pickler-only classvar was there and I didn't like copying that into _pickle.pyi.Pickler.memo and Unpickler.memo I went as far as I did with it because of the comment here: https://github.com/python/cpython/blob/3.12/Modules/_pickle.c#L4839
which pretty strongly implies that somebody out there is using it.