Update pytype to 2024.10.11 - #12778
Conversation
pytype 2024.10.11 fixes an issue around ParamSpec and circular imports.
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! Which versions of Python does this pytype version support? It seems like it's failing to be installed on Python 3.8 and 3.9
|
Looks like pytype dropped support for Python 3.8 and 3.9 in google/pytype@3537a44. Maybe we could solve this by only installing pytype for the specific pytype job in CI, though it'll be a shame if that means that we no longer get automated dependency updates from renovate (because it'll no longer be in |
|
Oops. Yes, that's right. In an attempt to make pytype easier to maintain we dropped support for older Python versions (3.8 and 3.9). We didn't realize those are still actively tested against in typeshed. We could add |
Very reasonable! A lot of this comes as a result of typeshed trying to install all of its test dependencies into a single environment. There's good reasons for doing it that way (mostly simplicity!) but it also naturally causes issues.
Yes, I think that should work! |
|
The stubtest failure is unrelated |
No worries. We're still new to the Python ecosystem. This is all a good learning experience. 🙂 Thanks for the quick response! |
pytype 2024.10.11 fixes an issue around ParamSpec and circular imports.
pytype 2024.10.11 also drops support for Python 3.8 and 3.9. To account for that, this PR adds a python_version restriction to requirements-tests.txt.
I tested this version with #12745 and confirmed that it fixes the issue.