Skip to content

Update pytype to 2024.10.11 - #12778

Merged
AlexWaygood merged 2 commits into
python:mainfrom
frigus02:pytype-2024.10.11
Oct 11, 2024
Merged

AlexWaygood merged 2 commits into
python:mainfrom
frigus02:pytype-2024.10.11

Conversation

@frigus02

@frigus02 frigus02 commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

pytype 2024.10.11 fixes an issue around ParamSpec and circular imports.

pytype 2024.10.11 also drops support for Python 3.8 and 3.9. To account for that, this PR adds a python_version restriction to requirements-tests.txt.

I tested this version with #12745 and confirmed that it fixes the issue.

pytype 2024.10.11 fixes an issue around ParamSpec and circular imports.

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Which versions of Python does this pytype version support? It seems like it's failing to be installed on Python 3.8 and 3.9

@AlexWaygood

AlexWaygood commented Oct 11, 2024

Copy link
Copy Markdown
Member

Looks like pytype dropped support for Python 3.8 and 3.9 in google/pytype@3537a44. Maybe we could solve this by only installing pytype for the specific pytype job in CI, though it'll be a shame if that means that we no longer get automated dependency updates from renovate (because it'll no longer be in requirements-tests.txt)

@frigus02

Copy link
Copy Markdown
Contributor Author

Oops. Yes, that's right. In an attempt to make pytype easier to maintain we dropped support for older Python versions (3.8 and 3.9). We didn't realize those are still actively tested against in typeshed.

We could add and python_version >= "3.10" to pytype in requirements-tests.txt. Would that help?

@AlexWaygood

AlexWaygood commented Oct 11, 2024

Copy link
Copy Markdown
Member

Oops. Yes, that's right. In an attempt to make pytype easier to maintain we dropped support for older Python versions (3.8 and 3.9). We didn't realize those are still actively tested against in typeshed.

Very reasonable! A lot of this comes as a result of typeshed trying to install all of its test dependencies into a single environment. There's good reasons for doing it that way (mostly simplicity!) but it also naturally causes issues.

We could add and python_version >= "3.10" to pytype in requirements-tests.txt. Would that help?

Yes, I think that should work!

@AlexWaygood

Copy link
Copy Markdown
Member

The stubtest failure is unrelated

@AlexWaygood
AlexWaygood merged commit a73c77a into python:main Oct 11, 2024
@frigus02
frigus02 deleted the pytype-2024.10.11 branch October 11, 2024 11:09
@frigus02

Copy link
Copy Markdown
Contributor Author

There's good reasons for doing it that way (mostly simplicity!) but it also naturally causes issues.

No worries. We're still new to the Python ecosystem. This is all a good learning experience. 🙂

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants