move _operator classes to operator - #12745
Merged
Merged
Conversation
This matches what they call themselves at runtime
This comment has been minimized.
This comment has been minimized.
tungol
marked this pull request as draft
October 6, 2024 02:10
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
After some experimentation, the pytype failure seems to be related to the circular dependency. I'm not yet sure why this one is a problem when other circular dependencies have passed without issue. |
Contributor
Author
|
I created a minimal reproduction of the pytype error in https://github.com/tungol/pytype-error-reproduction and opened an issue with pytype here: google/pytype#1797 Interestingly, it only occurs if the file with ParamSpec is processed before the other one in the circular dependency loop. |
tungol
marked this pull request as ready for review
October 6, 2024 21:48
srittau
approved these changes
Oct 8, 2024
Collaborator
|
Seems fine to me, but I've marked it as deferred for now, until the pytype problem is addressed. |
srittau
added
the
status: deferred
Contributor
|
#12778 should unblock this. |
srittau
removed
the
status: deferred
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches what they call themselves at runtime.