Skip to content

improvement: Add AST subclass constructors #11880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 16 commits into from
May 18, 2024
Merged

improvement: Add AST subclass constructors #11880

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d5e0838
improvement: shift node location attributes to classes which have them
bzoracler May 9, 2024
75a2e8e
Update _ast.pyi
bzoracler May 9, 2024
f9a2cb9
improvement: add missing node field
bzoracler May 9, 2024
d886a45
improvement: add precise AST subclass constructors
bzoracler May 9, 2024
25d4dad
test: update allowlist
bzoracler May 9, 2024
70fdb52
fix: delegate version-specific nodes to separate allowlists
bzoracler May 9, 2024
c88c4aa
fix: typo in parameter
bzoracler May 9, 2024
1135b28
style: Shorten signatures
bzoracler May 9, 2024
9655775
fix: remove unnecessary keyword-only constraint
bzoracler May 10, 2024
bb880f2
improvement: don't require args of type `expr_context` to be passed t…
bzoracler May 10, 2024
c82a5fa
feat: empty list defaults in Python 3.13
bzoracler May 10, 2024
aea4c01
style: keep `_SliceAttributes` together with usage location
bzoracler May 10, 2024
1e489b1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 10, 2024
b82fc4e
fix: add missing `default_value` field for Python 3.13
bzoracler May 10, 2024
cc50db4
improvement: add new Python 3.13 class variable
bzoracler May 10, 2024
cc2cd65
fix: wrong attribute conditional location
bzoracler May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: delegate version-specific nodes to separate allowlists
  • Loading branch information
@bzoracler
bzoracler authored May 9, 2024
commit 70fdb526b51f6ba8df6eca362d4c3a83477f6fce
5 changes: 5 additions & 0 deletions tests/stubtest_allowlists/py310.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ os.path.join
# Allowlist entries that cannot or should not be fixed
# ==========

# Runtime AST node runtime constructor behaviour is too loose.
# For static typing, the loose behaviour is undesirable (https://github.com/python/typeshed/issues/8378).
# For the runtime, the loose behaviour is deprecated in Python 3.13 (https://github.com/python/cpython/issues/105858)
_?ast.pattern.__init__

# Side effects from module initialization
_compat_pickle.excname
email.contentmanager.maintype
Expand Down
5 changes: 5 additions & 0 deletions tests/stubtest_allowlists/py311.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ os.path.join
# Allowlist entries that cannot or should not be fixed
# ==========

# Runtime AST node runtime constructor behaviour is too loose.
# For static typing, the loose behaviour is undesirable (https://github.com/python/typeshed/issues/8378).
# For the runtime, the loose behaviour is deprecated in Python 3.13 (https://github.com/python/cpython/issues/105858)
_?ast.pattern.__init__

_ast.ImportFrom.level # None on the class, but never None on instances
_collections_abc.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7491. Pos-only differences also.
_weakref.ProxyType.__reversed__ # Doesn't really exist
Expand Down
6 changes: 6 additions & 0 deletions tests/stubtest_allowlists/py312.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ zoneinfo.ZoneInfo.from_file
# Allowlist entries that cannot or should not be fixed
# ==========

# Runtime AST node runtime constructor behaviour is too loose.
# For static typing, the loose behaviour is undesirable (https://github.com/python/typeshed/issues/8378).
# For the runtime, the loose behaviour is deprecated in Python 3.13 (https://github.com/python/cpython/issues/105858)
_?ast.pattern.__init__
_?ast.type_param.__init__

_ast.ImportFrom.level # None on the class, but never None on instances
_collections_abc.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7491. Pos-only differences also.
_weakref.ProxyType.__reversed__ # Doesn't really exist
Expand Down
1 change: 0 additions & 1 deletion tests/stubtest_allowlists/py3_common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ _ctypes.call_function
_?ast.AST.__init__
_?ast.excepthandler.__init__
_?ast.expr.__init__
_?ast.pattern.__init__
_?ast.stmt.__init__

# async at runtime, deliberately not in the stub, see #7491
Expand Down