Use apt-get to install packages - #11824
Merged
Merged
Conversation
This fixes a warning about using apt in script.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
Author
|
apt/stubtest is running amok at the moment, at least in GitHub's containers. Let's wait for that to be resolved, before trying this again. |
Collaborator
Author
|
Stubtest works again. Ready for review. |
hamdanal
reviewed
Apr 27, 2024
| # Tk's manual pages more than 10 years ago. Use the latest manual pages instead: | ||
| # | ||
| # $ sudo apt install tk-doc tcl-doc | ||
| # $ sudo apt-get install tk-doc tcl-doc |
Contributor
There was a problem hiding this comment.
apt-get is recommended for use in scripts while apt is still the recommended tool for interactive use. All other changes look good to me except this one which I think is better left unchanged as it describes commands to be executed in the terminal.
hamdanal
approved these changes
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a warning about using apt in script.