Re-order ruff runs in pre-commit - #11737
Merged
Merged
Conversation
Member
I think it's useful to keep it as it will make it significantly easier to e.g. drop support for Python 3.8, when the time comes |
AlexWaygood
reviewed
Apr 9, 2024
AlexWaygood
approved these changes
Apr 9, 2024
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
LGTM other than my YAML formatting nit 😄
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessary
sys.version_infoblocks removal should be run first as it can leave unused imports behind.Realistically this can probably be removed after #11694 and #11696 as the mypy-protobuf update no longer generate files with
UP036violations. But that's a later consideration.