Bump tensorflow to 2.16.* - #11696
Merged
Merged
Conversation
Avasam
added
the
help wanted
AlexWaygood
reviewed
Apr 1, 2024
Avasam
commented
Apr 1, 2024
AlexWaygood
reviewed
Apr 1, 2024
…/typeshed into bump-tensorflow-to-2.16.1
Avasam
commented
Apr 4, 2024
Avasam
commented
Apr 4, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…/typeshed into bump-tensorflow-to-2.16.1
…ensorflow-to-2.16.1
This comment has been minimized.
This comment has been minimized.
Avasam
removed
the
help wanted
This comment has been minimized.
This comment has been minimized.
…ensorflow-to-2.16.1
This comment has been minimized.
This comment has been minimized.
Avasam
marked this pull request as ready for review
April 14, 2024 16:49
Avasam
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Apr 15, 2024
This comment has been minimized.
This comment has been minimized.
…ensorflow-to-2.16.1
…/typeshed into bump-tensorflow-to-2.16.1
This comment has been minimized.
This comment has been minimized.
…ensorflow-to-2.16.1
This comment has been minimized.
This comment has been minimized.
…ensorflow-to-2.16.1
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: jax (https://github.com/google/jax)
- jax/experimental/jax2tf/tests/tf_test_util.py:114: error: Incompatible return value type (got "tuple[Any, Module]", expected "tuple[Callable[..., Any], Checkpoint]") [return-value]
|
srittau
approved these changes
Apr 22, 2024
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
I did not compare to the implementation, but the changes all seem reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11556
I skipped 2.15 in the script because it didn't lead to any difference
There's plenty of non-generated file changes to be reviewed.