Bump protobuf to v25.3 - #11694
Merged
Merged
Bump protobuf to v25.3#11694
Conversation
Avasam
added
status: deferred
This comment has been minimized.
This comment has been minimized.
Avasam
removed
status: deferred
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Apr 8, 2024
Avasam
commented
Apr 8, 2024
This comment has been minimized.
This comment has been minimized.
Further filter pre-commit run in generated scripts
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Apr 9, 2024
| args: ["--exit-non-zero-on-fix", "--select=UP036", "--unsafe-fixes"] | ||
| - id: ruff | ||
| name: Run ruff on stubs, tests and scripts | ||
| args: ["--exit-non-zero-on-fix"] |
Collaborator
There was a problem hiding this comment.
Could you move this to an separate PR, for cleaner separation of concerns?
Avasam
commented
Apr 9, 2024
Avasam
commented
Apr 9, 2024
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11693
Do not merge untiltypes-protobuf==4.24has been published to PyPI !Bumped mypy-protobuf to 3.6
Ran stub defaulter.