Bump to protobuf==24.4 - #11686
Bump to protobuf==24.4#11686ijknabla wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Cc @nipunn1313 |
|
Hi @ijknabla , since these files are auto-generated, one should also update the generator script along with them! Otherwise we risk loosing these changes and/or creating confusion next time they're run. |
|
Thanks to @Avasam , I now have a better understanding of the issues. Latest release of types-protobuf 4.24.0.20240311 seems to provide a type hint for The referenced script shows that when typeshed/scripts/generate_proto_stubs.sh Line 15 in 28fe4cc Can we change to |
|
Oh, Simple change did not work. # followed by committing the changes to typeshed
#
# Update these two variables when rerunning script
-PROTOBUF_VERSION=21.8
-PYTHON_PROTOBUF_VERSION=4.21.8
+PROTOBUF_VERSION=24.0
+PYTHON_PROTOBUF_VERSION=4.24.0
MYPY_PROTOBUF_VERSION=3.5.0I think that this is caused by a change in the release structure of protobuf.
If we don't think about script compatibility, we could solve this problem by simply updating the URL in the shell script. |
|
@ijknabla I'm working on updating the script for v22+ as we speak, expect a PR soon |
|
script compatibility for generate_proto_stubs.sh is not important! But in general, protobuf python API is pretty stable, so I think you can go for it. |
|
I would expect some changes to METADATA.toml to happen as part of this PR too. |
|
seems like we could bump to 25 and 26 as well |
|
I just released mypy-protobuf 3.6.0 that is confirmed compatible to protobuf 3.25. I propose that you continue with this PR bumping to 24.4 - then later we can bump to 25 and a bit later after that 26. |
|
Thanks to all of you for your help in resolving this. |
#11685