Use uv for installing dynamic dependencies in mypy_test.py and regr_test.py#11517
Merged
Conversation
…t.py` and `stubtest_third_party.py`
AlexWaygood
commented
Mar 1, 2024
| source .venv/bin/activate | ||
| echo "Installing packages: $DEPENDENCIES" | ||
| uv pip install $DEPENDENCIES --system | ||
| uv pip install $DEPENDENCIES |
Member
Author
There was a problem hiding this comment.
This just fixes a slight oversight from #11515. We've already created a virtual environment here (we were doing so before we switched to uv), so there's no need to use the --system flag here.
Member
Author
|
Interesting! I guess we can't do Dog-fooding is so useful :) |
AlexWaygood
changed the title
uv for installing dynamic dependencies in mypy_test.py, regr_test.py and stubtest_third_party.pyuv for installing dynamic dependencies in mypy_test.py and regr_test.py
JelleZijlstra
approved these changes
Mar 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution time of
mypy_test.pygoes down from around 2m10s to around 1m30s in CI