Skip to content

[stubsabot] Bump protobuf to 5.26.* - #10964

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
stubsabot/protobuf
Closed

[stubsabot] Bump protobuf to 5.26.*#10964
github-actions[bot] wants to merge 1 commit into
mainfrom
stubsabot/protobuf

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Release: https://pypi.org/pypi/protobuf/5.26.1
Homepage: https://developers.google.com/protocol-buffers/
Repository: https://github.com/protocolbuffers/protobuf
Typeshed stubs: https://github.com/python/typeshed/tree/main/protobuf

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

@github-actions github-actions Bot added the bot: stubsabot 🤖 Third-party stub updates by stubsabot 🤖 label Nov 2, 2023
@AlexWaygood AlexWaygood closed this Nov 2, 2023
@AlexWaygood AlexWaygood reopened this Nov 2, 2023
@github-actions github-actions Bot changed the title [stubsabot] Bump protobuf to 4.25.* [stubsabot] Bump protobuf to 5.26.* Mar 14, 2024
@Avasam Avasam mentioned this pull request Apr 1, 2024
Merged
@Avasam

Avasam commented Apr 8, 2024

Copy link
Copy Markdown
Collaborator

protobuf v26 removed the root setup.py so logic will have to be updated in

typeshed/scripts/generate_proto_stubs.sh

Lines 52 to 66 in 1d33abb

# Roughly reproduce the subset of .proto files on the public interface as described
# by find_package_modules in the protobuf setup.py.
# The logic (as of 3.20.1) can roughly be described as a allowlist of .proto files
# further limited to exclude *test* and internal/
# https://github.com/protocolbuffers/protobuf/blob/master/python/setup.py
PROTO_FILES=$(grep "GenProto.*google" $PYTHON_PROTOBUF_DIR/python/setup.py | \
cut -d\' -f2 | \
grep -v "test" | \
grep -v google/protobuf/internal/ | \
grep -v google/protobuf/pyext/python.proto | \
grep -v src/google/protobuf/util/json_format.proto | \
grep -v src/google/protobuf/util/json_format_proto3.proto | \
sed "s:^:$PYTHON_PROTOBUF_DIR/python/:" | \
xargs -L1 realpath --relative-to=. \
)

stubsabot
[stubsabot] Bump protobuf to 5.26.*
740cada 
Release: https://pypi.org/pypi/protobuf/5.26.1
Homepage: https://developers.google.com/protocol-buffers/
Repository: https://github.com/protocolbuffers/protobuf
Typeshed stubs: https://github.com/python/typeshed/tree/main/protobuf

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
@Avasam Avasam self-assigned this Apr 17, 2024
@Avasam

Avasam commented Apr 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

After a bit of investigation, it's because they dropped a build backend they were considering obsolete. Updating the logic to pull from the bazel build file instead actually simplifies our script with the same result. PR soon.

@Avasam Avasam mentioned this pull request Apr 18, 2024
Merged
@AlexWaygood
AlexWaygood deleted the stubsabot/protobuf branch April 19, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Avasam Avasam

Labels

bot: stubsabot 🤖 Third-party stub updates by stubsabot 🤖

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avasam @AlexWaygood